ref(perf): Move out the span transactions table #69771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only used here!
Remove conditional routing and unused parameters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 4.67kB ⬆️
|
0Calories
approved these changes
May 8, 2024
| field: (typeof SORTABLE_FIELDS)[number]; | ||
| }; | ||
|
|
||
| export function isAValidSort(sort: Sort): sort is ValidSort { |
| sorts: [sort], | ||
| limit: TRANSACTIONS_TABLE_ROW_COUNT, | ||
| cursor, | ||
| referrer: 'api.starfish.span-transaction-metrics', |
There was a problem hiding this comment.
we should probably rename this referrer eventually
There was a problem hiding this comment.
Yes, definitely! Cleaning up referrers everywhere is on my list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's gross! In short, we had a component called the
SpanTransactionsTable. It was a transactions table with some conditional logic, to render different columns and fetch different data depending on what module was using it.The problem? The only module using it is the database module. So, I'm dumping this "dynamic" table, and replacing it with a normal table, the kind we have all over the place. This will make it easier to consolidate the code, and remove a few rarely-used utils like
extractRoute.I'm also removing some cruft like the competing
endpointandtransactionparameters that we don't use anymore, lifting up the data loading state, etc.