Raise an error rather than relying on Snuba telling us #69575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
force-pushed
the
feat/discover/complain_empty_projects/armenzg
branch
from
2e5f04e
to
ef8615e
Compare
armenzg
force-pushed
the
feat/discover/complain_empty_projects/armenzg
branch
from
ef8615e
to
6a8d5c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/discover/complain_empty_projects/armenzg #69575 +/- ##
==============================================================================
Coverage 79.65% 79.65%
==============================================================================
Files 6472 6472
Lines 287395 287475 +80
Branches 49536 49547 +11
==============================================================================
+ Hits 228913 228999 +86
+ Misses 58114 58108 -6
Partials 368 368
|
Base automatically changed from
feat/discover/complain_empty_projects/armenzg
to
master
April 25, 2024 11:58
armenzg
added a commit
that referenced
this pull request
Apr 25, 2024
…69577) I discovered that we can make calls to Snuba with an empty list of `project_ids` (which is a required field) and that _always_ returns no data. This may not be happening in production, however, during development, this can take a lot of time to debug. In production, we will raise an error rather than calling Snuba, thus, helping us find any issues in production. During development, we will call Snuba _without_ `project_ids` which will cause an error from Snuba and help a developer notice the problem. We're doing this since there are a lot of tests in our codebase which require including the list of projects before calling Snuba (You can see some of the failures in #69575 ). We should eventually fix it, however, it requires significant effort.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR raises an error if
project_idsare not defined. It requires some extra work to fix a bunch of tests.It's based on #69577