Hook up peanutbutter as an LPQ backend
#69187
Conversation
Peanutbutter is a self contained service managing per-project budgets. It should eventually replace the existing `realtime_metrics` code which uses redis and celery in an extremely inefficient way.
github-actions
bot
added
the
Scope: Backend
src/sentry/conf/server.py
Outdated
| "image": "us.gcr.io/sentryio/peanutbutter:latest", | ||
| "environment": {}, | ||
| "ports": {"4433/tcp": 4433}, | ||
| "only_if": False, # TODO: we do not want/need this in normal devservices, but we need it for certain tests |
There was a problem hiding this comment.
@asottile-sentry related to your comment in #67232 (comment):
I removed the wrapper to start this server on demand. but that also means that needs to be running in the background, which is a bit overkill as this is otherwise not used for a local devserver.
Although its also very low overhead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #69187 +/- ##
==========================================
- Coverage 80.00% 79.93% -0.08%
==========================================
Files 6507 6450 -57
Lines 290809 288341 -2468
Branches 50125 49714 -411
==========================================
- Hits 232669 230480 -2189
+ Misses 57704 57424 -280
- Partials 436 437 +1
|
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
src/sentry/conf/server.py
Outdated
| # This flags enables the `peanutbutter` realtime metrics backend. | ||
| # See https://github.com/getsentry/peanutbutter. | ||
| # TODO: we do not want/need this in normal devservices, but we need it for certain tests | ||
| SENTRY_USE_PEANUTBUTTER = True |
There was a problem hiding this comment.
@asottile-sentry As @Swatinem mentions, we need to enable peanutbutter to run a test. Is this the appropriate way to do this? Is it okay to start this by default?
There was a problem hiding this comment.
for disabled by default you'd want False and to add it to the github action setup in .github/workflows/backend.yml / .github/actions/setup-sentry
There was a problem hiding this comment.
Thank you for the explanation, I hope I did it right.
Peanutbutter is a self contained service managing per-project budgets.
It should eventually replace the existing
realtime_metricscode which uses redis and celery in an extremely inefficient way.This replaces #67232, now using HTTP.