fix: remove set-cache-item experiment

[anonrig]

The experiment/feature flag was a success. We can remove it now.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (ef9d8e9) to head (908c1b9).
Report is 11 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #68896   +/-   ##
=======================================
  Coverage   77.89%   77.89%           
=======================================
  Files        6519     6519           
  Lines      290468   290467    -1     
  Branches    50264    50264           
=======================================
+ Hits       226263   226264    +1     
+ Misses      57964    57963    -1     
+ Partials     6241     6240    -1     

Files	Coverage Δ
src/sentry/db/models/fields/node.py	77.03% <100.00%> (ø)
src/sentry/issues/escalating_group_forecast.py	96.77% <ø> (ø)
src/sentry/nodestore/base.py	84.67% <100.00%> (-0.13%)	⬇️

... and 9 files with indirect coverage changes

[anonrig]

@markstory @mitsuhiko I had to remove several tests and add a field for override_cache option to preserve the existing change for several fields. Can you validate if the change is indeed correct, or do we NOT need any override_cache option, and just simply remove/update the tests that rely on this behavior?

[markstory]

I'm not familiar with the nuances of escalating issues, but the NodeData change looks good to me.

[markstory]

This write to cache makes sense to me. The node could be in cache (because of a read) and any update to the data should also reflect in future reads which could be served from cache.

[getsantry]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀