Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(indexer): Add metrics around join time for chained processing strategies #68828

Closed
wants to merge 1 commit into from

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Apr 12, 2024

Currently, we have a total shutdown time for the indexer; however, we don't have a better breakdown to understand which strategies make up this shutdown time and how much.

@ayirr7 ayirr7 requested a review from a team as a code owner April 12, 2024 20:09
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.72%. Comparing base (910ff45) to head (723e323).
Report is 1268 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #68828   +/-   ##
=======================================
  Coverage   79.72%   79.72%           
=======================================
  Files        6420     6422    +2     
  Lines      284558   284641   +83     
  Branches    49022    49039   +17     
=======================================
+ Hits       226868   226940   +72     
- Misses      57324    57335   +11     
  Partials      366      366           
Files Coverage Δ
.../sentry/sentry_metrics/consumers/indexer/common.py 95.87% <100.00%> (+0.04%) ⬆️
...entry/sentry_metrics/consumers/indexer/parallel.py 81.72% <100.00%> (+0.60%) ⬆️

... and 19 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented May 9, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label May 9, 2024
@getsantry getsantry bot closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants