Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onboarding for Go Fiber #68665

Closed
wants to merge 5 commits into from
Closed

Add onboarding for Go Fiber #68665

wants to merge 5 commits into from

Conversation

ribice
Copy link

@ribice ribice commented Apr 10, 2024

No description provided.

@ribice ribice requested a review from a team as a code owner April 10, 2024 22:39
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 10, 2024
@ribice ribice requested a review from a team as a code owner April 18, 2024 00:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 18, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 79.97%. Comparing base (e9071c2) to head (9ea7d87).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #68665      +/-   ##
==========================================
- Coverage   79.97%   79.97%   -0.01%     
==========================================
  Files        6500     6501       +1     
  Lines      290312   290328      +16     
  Branches    50021    50021              
==========================================
+ Hits       232191   232194       +3     
+ Misses      57754    57687      -67     
- Partials      367      447      +80     
Files Coverage Δ
src/sentry/models/project.py 97.35% <ø> (ø)
src/sentry/utils/platform_categories.py 100.00% <ø> (ø)
...components/onboarding/frameworkSuggestionModal.tsx 67.07% <ø> (ø)
static/app/data/platformCategories.tsx 100.00% <ø> (ø)
static/app/data/platformPickerCategories.tsx 100.00% <ø> (ø)
static/app/data/platforms.tsx 100.00% <ø> (ø)
static/app/gettingStartedDocs/go/fiber.tsx 68.75% <68.75%> (ø)

... and 100 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented May 9, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label May 9, 2024
@getsantry getsantry bot closed this May 17, 2024
@ribice
Copy link
Author

ribice commented May 17, 2024

cc @cleptric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant