feat(discover): Prevent calling Snuba with an empty list of projects

[armenzg]

Do not include a where condition if project_ids is an empty list since it will return no data.
This will cause Snuba to respond that project_ids is missing rather than pretend that everything is fine.

In #69575 I attempt to save the call to Snuba but it requires a lot of test changes.

[armenzg]

I messed up #69499 so I had to open this one.

[wmak]

🙏 thanks for tackling this

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.67%. Comparing base (34d9222) to head (c03b6e6).
Report is 53 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #69577      +/-   ##
==========================================
- Coverage   79.68%   79.67%   -0.01%     
==========================================
  Files        6483     6483              
  Lines      287949   287909      -40     
  Branches    49642    49619      -23     
==========================================
- Hits       229438   229385      -53     
- Misses      58140    58153      +13     
  Partials      371      371              

Files	Coverage Δ
src/sentry/utils/snuba.py	93.62% <100.00%> (-0.13%)	⬇️
src/sentry/search/events/builder/discover.py	96.21% <80.00%> (-0.10%)	⬇️

... and 21 files with indirect coverage changes

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ UnqualifiedQueryError: validation failed for entity discover_events: Entity discover_events: Query column 'measurements'... /api/0/organizations/{organization_slug}/issues/ View Issue
• ‼️ UnqualifiedQueryError: validation failed for entity events: missing required conditions for project_id /api/0/organizations/{organization_slug}/issues... View Issue
• ‼️ UnqualifiedQueryError: You need to specify at least one project. /api/0/organizations/{organization_slug}/replay... View Issue
• ‼️ UnqualifiedQueryError: Not a valid UUID string /api/0/organizations/{organization_slug}/replay... View Issue
• ‼️ UnqualifiedQueryError: Not a valid UUID string /api/0/organizations/{organization_slug}/replay... View Issue

_{Did you find this useful? React with a 👍 or 👎}