Skip to content

Commit

Permalink
chore(issues): Enable stronger typing on occurrence_consumer (#70487)
Browse files Browse the repository at this point in the history
This is a quick follow up to #69828 since these two type errors are
trivial to resolve.
  • Loading branch information
mrduncan authored and armenzg committed May 9, 2024
1 parent 0696a68 commit cc7a7d1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ module = [
"sentry.issues.issue_occurrence",
"sentry.issues.json_schemas",
"sentry.issues.merge",
"sentry.issues.occurrence_consumer",
"sentry.issues.ongoing",
"sentry.issues.priority",
"sentry.issues.producer",
Expand Down
4 changes: 2 additions & 2 deletions src/sentry/issues/occurrence_consumer.py
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def _process_message(
return None


def _process_batch(worker: ThreadPoolExecutor, message: Message[ValuesBatch[KafkaPayload]]):
def _process_batch(worker: ThreadPoolExecutor, message: Message[ValuesBatch[KafkaPayload]]) -> None:
"""
Receives batches of occurrences. This function will take the batch
and group them together by fingerprint (ensuring order is preserved) and
Expand Down Expand Up @@ -402,7 +402,7 @@ def _process_batch(worker: ThreadPoolExecutor, message: Message[ValuesBatch[Kafk
wait(futures)


def process_occurrence_group(items: list[Mapping[str, Any]]):
def process_occurrence_group(items: list[Mapping[str, Any]]) -> None:
"""
Process a group of related occurrences (all part of the same group)
completely serially.
Expand Down

0 comments on commit cc7a7d1

Please sign in to comment.