[SR] Align breadcrumbs with frontend #3406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c5a385c | 371.06 ms | 433.14 ms | 62.08 ms |
| 0a9348e | 330.94 ms | 405.53 ms | 74.59 ms |
| 51792bd | 461.35 ms | 479.57 ms | 18.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c5a385c | 1.70 MiB | 2.33 MiB | 638.75 KiB |
| 0a9348e | 1.70 MiB | 2.32 MiB | 638.56 KiB |
| 51792bd | 1.70 MiB | 2.33 MiB | 640.05 KiB |
…on-replay-breadcrumbs-v2
markushi
approved these changes
May 8, 2024
| @@ -18,7 +18,7 @@ public void serialize(final @NotNull ObjectWriter writer, final @NotNull ILogger | |||
| writer.value(name().toLowerCase(Locale.ROOT)); | |||
| } | |||
|
|
|||
| static final class Deserializer implements JsonDeserializer<SentryLevel> { | |||
| public static final class Deserializer implements JsonDeserializer<SentryLevel> { | |||
There was a problem hiding this comment.
would it make sense to mark it as @ApiStatus.Internal then?
| if (isBatteryChanged) { | ||
| final Float batteryLevel = DeviceInfoUtil.getBatteryLevel(intent, options); | ||
| if (batteryLevel != null) { | ||
| breadcrumb.setData("level", batteryLevel); |
There was a problem hiding this comment.
float is fine here right? The notion doc is not 100% clear about this.
vaind
reviewed
May 15, 2024
| var breadcrumbMessage: String? = null | ||
| val breadcrumbCategory: String? | ||
| var breadcrumbCategory: String? = null | ||
| var breadcrumbLevel: SentryLevel? = null | ||
| val breadcrumbData = mutableMapOf<String, Any?>() | ||
| when { |
There was a problem hiding this comment.
@romtsn what do you think about extracting this to a class so we can override it from RN and Flutter to have custom mapping?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
💡 Motivation and Context
Part of getsentry/sentry#70065