POTEL 2 - Promote OpenTelemetry Span attributes #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- POTEL 2 - Promote OpenTelemetry Span attributes ([#3402](https://github.com/getsentry/sentry-java/pull/3402))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9931715 | 374.85 ms | 431.48 ms | 56.62 ms |
| 9a9af11 | 376.72 ms | 442.33 ms | 65.61 ms |
| f5f9136 | 395.57 ms | 504.94 ms | 109.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9931715 | 1.70 MiB | 2.28 MiB | 596.01 KiB |
| 9a9af11 | 1.70 MiB | 2.28 MiB | 596.17 KiB |
| f5f9136 | 1.70 MiB | 2.28 MiB | 596.01 KiB |
lbloder
reviewed
May 3, 2024
| } | ||
|
|
||
| @SuppressWarnings("deprecation") | ||
| private OtelSpanInfo extractSpanDescription(SpanData otelSpan) { |
There was a problem hiding this comment.
Couldn't we have the overloaded method receiving ReadableSpan call this method with ReadableSpan.toSpanData()?
| } | ||
|
|
||
| @SuppressWarnings("deprecation") | ||
| private OtelSpanInfo descriptionForHttpMethod( |
There was a problem hiding this comment.
Couldn't we have the overloaded method receiving ReadableSpan call this method with ReadableSpan.toSpanData()?
| } | ||
|
|
||
| @SuppressWarnings("deprecation") | ||
| private OtelSpanInfo descriptionForDbSystem(final @NotNull SpanData otelSpan) { |
There was a problem hiding this comment.
Couldn't we have the overloaded method receiving ReadableSpan call this method with ReadableSpan.toSpanData()?
…l-2-promote-span-attributes
…l-2-promote-span-attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Sentry features like "Requests" need certain attributes to work, e.g. span
opshould be "METHOD URL", response status code should be in span data.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps