Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply a token for CODECOV and bump to action v4 #3342

Merged
merged 4 commits into from May 13, 2024
Merged

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Apr 11, 2024

#skip-changelog

馃摐 Description

Supply a token and use v4 of codecov-action

馃挕 Motivation and Context

Without a token codecov API usage may be rate limited. This should prevent it.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 390.22 ms 485.49 ms 95.27 ms
Size 1.70 MiB 2.28 MiB 592.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0404ea3 394.73 ms 461.79 ms 67.06 ms
d007225 365.63 ms 438.24 ms 72.62 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
8838e01 387.41 ms 467.00 ms 79.59 ms
4e29063 384.14 ms 447.74 ms 63.60 ms
4e260b3 388.40 ms 468.98 ms 80.58 ms
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
95a98b5 379.14 ms 420.80 ms 41.66 ms
a33b076 390.44 ms 460.29 ms 69.85 ms
2465853 422.61 ms 491.20 ms 68.58 ms

App size

Revision Plain With Sentry Diff
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
d007225 1.70 MiB 2.27 MiB 586.31 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
8838e01 1.72 MiB 2.29 MiB 578.15 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
95a98b5 1.70 MiB 2.27 MiB 586.31 KiB
a33b076 1.70 MiB 2.28 MiB 592.32 KiB
2465853 1.70 MiB 2.27 MiB 583.82 KiB

Previous results on branch: adinauer-patch-1

Startup times

Revision Plain With Sentry Diff
cc070f9 404.94 ms 468.22 ms 63.28 ms
8f0708b 372.85 ms 446.00 ms 73.15 ms

App size

Revision Plain With Sentry Diff
cc070f9 1.70 MiB 2.28 MiB 592.32 KiB
8f0708b 1.70 MiB 2.28 MiB 592.12 KiB

@adinauer adinauer merged commit f1fdb9f into main May 13, 2024
25 checks passed
@adinauer adinauer deleted the adinauer-patch-1 branch May 13, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants