New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move NDK from sentry-java to sentry-native #3189
base: 8.x.x
Are you sure you want to change the base?
Conversation
|
sentry-android-ndk/build.gradle.kts
Outdated
@@ -101,6 +71,8 @@ dependencies { | |||
api(projects.sentry) | |||
api(projects.sentryAndroidCore) | |||
|
|||
implementation("io.sentry:sentry-native-ndk:0.7.20") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll probably need to make our dependency updater work for this module too
@@ -7,7 +7,7 @@ public final class io/sentry/android/ndk/BuildConfig { | |||
} | |||
|
|||
public final class io/sentry/android/ndk/DebugImagesLoader : io/sentry/android/core/IDebugImagesLoader { | |||
public fun <init> (Lio/sentry/android/core/SentryAndroidOptions;Lio/sentry/android/ndk/NativeModuleListLoader;)V | |||
public fun <init> (Lio/sentry/android/core/SentryAndroidOptions;Lio/sentry/ndk/NativeModuleListLoader;)V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This smells like a breaking change - should we make it part of v8 actually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except that it's binary-incompatible with older versions now, maybe we should make it part of v8?
📜 Description
Relevant
sentry-native
PR: getsentry/sentry-native#944To make this branch work, you need to publish the sentry-native ndk artifact first:
cd sentry-native/ndk
./gradlew :lib:publishToMavenLocal
💡 Motivation and Context
Move NDK code over to sentry-native, to make it more testable and robust.
💚 How did you test it?
It's reusing the existing tests.
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps