feat(tracing without performance): add ContinueTrace #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etsentry#745) * feat(tracing without performance): add propagation context to scope * remove redundant dynamic context assignment * more tests
Add ContinueTrace as a method on the hub. This is how other SDKs that have to deal with concurrency tend to do it, ie Java.
cleptric
reviewed
Dec 19, 2023
| @@ -400,6 +401,31 @@ func (scope *Scope) ApplyToEvent(event *Event, hint *EventHint) *Event { | |||
| } | |||
| } | |||
|
|
|||
| // Apply the trace context to errors if there is a Span on the scope. If | |||
| // there isn't then fall back to the propagation context. | |||
| if event.Type != transactionType { | |||
There was a problem hiding this comment.
Could we also use this for transactions, so it's centralized?
There was a problem hiding this comment.
Yeah, looking at the code now that makes sense. I'll make the change. :)
cleptric
reviewed
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ContinueTrace as a method on the hub. This is how other SDKs that have to deal with concurrency tend to do it, ie Java.