Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update DeviceTests from upstream #2853

Draft
wants to merge 74 commits into
base: main
Choose a base branch
from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Nov 16, 2023

Originally this started as an update of DeviceTests to .net8 but there are errors which I've hoped would be fixed by updating the copy of MauiTestUtils we have from upstream. Turns out it didn't fix the issue but I'd still keep the update, just don't want to have it in the same repo so it's hard to review.

This PR doesn't really need a code review because all the code is just copied over from https://github.com/dotnet/maui/tree/a19fbb776090b46d42cea3b4d5553c4c8e8a3ec3/src/TestUtils/src

#skip-changelog

@vaind vaind changed the base branch from main to feat/4.0.0 November 16, 2023 15:19
@vaind vaind force-pushed the chore/update-maui-devicetests branch from 1ae3f3e to 3b0ef43 Compare November 16, 2023 19:25
@vaind vaind changed the title chore: Update DeviceTests to NET8 chore: Update DeviceTests from upstream Nov 16, 2023
@vaind vaind force-pushed the chore/update-maui-devicetests branch from 3b0ef43 to 3f0400c Compare November 16, 2023 19:28
Base automatically changed from feat/4.0.0 to main November 27, 2023 19:49
Giorgi and others added 30 commits December 27, 2023 13:00
* Attach screenshot

* Add AttachScreenshots option default value test

* Update changelog

* Update changelog

* Add AttachScreenshots to bindable options.

* Add AttachScreenshots to verify

* Fix verify test

* Remove default for AttachScreenshots

* Use hint for screenshot attachments

* Update CHANGELOG.md

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

* Add screenshot processor on options

* Add comment, skip on Windows

* Move try/catch outside #if

* Don't add screenshot processor to scope.

* Log if screenshot cannot be captured.

* Add tests

* Find envelope by id.

* Assert attachment item only on mobile.

* Initialize ActivityStateManager

* Capture screen on UI thread.

* Init platform

* Move init to MainApplication

* Use extension methods on SentryOptions for logging

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

* Add missing using

* Init platform in lifecycle events

* Remove MainApplication from device tests

* Write to logcat

* Rename Property

* Pass AttachScreenshot to native sdk options.

* Move CaptureFailed outside of #Debug

* Remove leftover code

* Remove Logcat logging

* Update CHANGELOG.md

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

* Use blocking call on main thread

* Set debug mode to make logs work

* Update src/Sentry.Maui/SentryMauiOptions.cs

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>

* Remove try catch from screen capture

* Rename file to match class name

---------

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: GitHub <noreply@github.com>
…2995)

Bumps [gradle/gradle-build-action](https://github.com/gradle/gradle-build-action) from 2.11.0 to 2.11.1.
- [Release notes](https://github.com/gradle/gradle-build-action/releases)
- [Commits](gradle/gradle-build-action@8cbcb99...982da8e)

---
updated-dependencies:
- dependency-name: gradle/gradle-build-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update internal dependencies

* roll back verify.xunit

* roll back xunit.runner.visualstudio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants