-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename resource module to asset module #10047
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 216 bytes ⬆️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine but you'll want to double check the following before merging:
- Add redirect for this page to middleware.ts (see https://docs.sentry.io/contributing/pages/redirects/#add-a-new-redirect-in-middlewarets-recommended)
- Are the widgets affected by this change? Might need to update these sections:
- https://docs.sentry.io/product/performance/filters-display/widgets/#most-time-consuming-resources
- https://docs.sentry.io/product/performance/filters-display/widgets/#slow-resource-ops
- https://docs.sentry.io/product/performance/filters-display/#actionable-widgets
- Since you're changing the file name, will also want to do a search to update any links that were going directly to the resources page (for example, links here https://docs.sentry.io/product/performance/filters-display/widgets/#most-time-consuming-resources)
We should also update the arcades included in these docs. I can help with that; just give me a heads up for when this change is planning to launch!
@vivianyentran we plan to release this on June 5th, r we able to update the arcades by then? Also, do the links need be changed? |
@DominikB2014 Yes, we should be able to update the arcades by then. Are all the changes live in the sentry org to capture screenshots? |
@DominikB2014 Yes, you should also update any links that point to the old path |
@vivianyentran the updates should be live eod today, I'll follow up with you on slack when it's done! |
Renaming the `resources` module to `assets` resonates better with FE devs. This does all the renaming in sentry itself, and there's another PR up for docs getsentry/sentry-docs#10047 --------- Co-authored-by: George Gritsouk <989898+gggritso@users.noreply.github.com>
Added redirects!
Yes, just updated the screenshot for this widget No, this one stays the same! Updated the link!
Looked through, and not seeing any more links to be updated |
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Asset module probably resonates better with FE devs, so we should rename the module