-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testflight: build with 鈥攐bfuscate --split-debug-info flags #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@buenaflor Ok, source context does actually work now. We should merge this, as this was missing. |
sounds good, how does the grouping look like now? |
Grouping works if the flags are applied the same for both platforms. #1983 (comment) |
denrase
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
June 3, 2024 11:37
Android Performance metrics 馃殌
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e66e71e | 296.84 ms | 345.43 ms | 48.59 ms |
df16b96 | 326.08 ms | 391.82 ms | 65.74 ms |
95d0636 | 301.46 ms | 357.98 ms | 56.52 ms |
3e33891 | 313.60 ms | 379.51 ms | 65.91 ms |
ee0ca56 | 355.35 ms | 421.13 ms | 65.78 ms |
3a43905 | 334.12 ms | 404.02 ms | 69.90 ms |
7f75f32 | 347.36 ms | 419.58 ms | 72.22 ms |
1b66358 | 314.96 ms | 363.39 ms | 48.43 ms |
24b6e60 | 440.64 ms | 557.96 ms | 117.32 ms |
202b83f | 357.79 ms | 419.47 ms | 61.68 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e66e71e | 6.06 MiB | 7.09 MiB | 1.03 MiB |
df16b96 | 6.06 MiB | 7.03 MiB | 988.94 KiB |
95d0636 | 6.16 MiB | 7.14 MiB | 1007.32 KiB |
3e33891 | 6.16 MiB | 7.14 MiB | 1007.46 KiB |
ee0ca56 | 6.33 MiB | 7.30 MiB | 992.52 KiB |
3a43905 | 6.06 MiB | 7.03 MiB | 996.98 KiB |
7f75f32 | 6.26 MiB | 7.20 MiB | 959.18 KiB |
1b66358 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
24b6e60 | 6.33 MiB | 7.26 MiB | 950.14 KiB |
202b83f | 6.34 MiB | 7.28 MiB | 966.66 KiB |
iOS Performance metrics 馃殌
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6aab859 | 1245.14 ms | 1247.59 ms | 2.45 ms |
9c5aec6 | 1266.51 ms | 1274.65 ms | 8.14 ms |
895becc | 1288.00 ms | 1308.63 ms | 20.63 ms |
24b6e60 | 1250.69 ms | 1268.63 ms | 17.94 ms |
8d64376 | 1260.92 ms | 1289.32 ms | 28.40 ms |
eb1a7c1 | 1281.25 ms | 1295.40 ms | 14.15 ms |
8cb6557 | 1265.14 ms | 1266.08 ms | 0.94 ms |
f0fcbe1 | 1238.08 ms | 1243.44 ms | 5.36 ms |
d189e01 | 1219.94 ms | 1228.20 ms | 8.27 ms |
559d28f | 1265.04 ms | 1288.96 ms | 23.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6aab859 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
9c5aec6 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
895becc | 8.10 MiB | 9.18 MiB | 1.08 MiB |
24b6e60 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
8d64376 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
eb1a7c1 | 8.15 MiB | 9.13 MiB | 1000.10 KiB |
8cb6557 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
f0fcbe1 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
d189e01 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
559d28f | 8.15 MiB | 9.12 MiB | 987.32 KiB |
buenaflor
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
馃摐 Description
build with 鈥攐bfuscate --split-debug-info flags
馃挕 Motivation and Context
Relates to #1983
馃摑 Checklist
sendDefaultPii
is enabled