-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse PlatformException from details instead of message #2052
Open
denrase
wants to merge
7
commits into
main
Choose a base branch
from
fix/parse-platform-exception-from-details
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
051e97a | 359.56 ms | 426.68 ms | 67.12 ms |
3e9fb0e | 329.14 ms | 359.16 ms | 30.02 ms |
4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
8ced2dc | 295.58 ms | 336.49 ms | 40.91 ms |
2261c15 | 370.00 ms | 455.88 ms | 85.88 ms |
30c1193 | 349.00 ms | 438.20 ms | 89.20 ms |
e66e71e | 296.84 ms | 345.43 ms | 48.59 ms |
62dde43 | 339.21 ms | 423.06 ms | 83.85 ms |
5aab4c5 | 326.12 ms | 378.82 ms | 52.70 ms |
5e8d2b3 | 342.17 ms | 375.83 ms | 33.66 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
051e97a | 6.27 MiB | 7.20 MiB | 959.09 KiB |
3e9fb0e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
8ced2dc | 6.06 MiB | 7.03 MiB | 990.29 KiB |
2261c15 | 6.27 MiB | 7.20 MiB | 957.75 KiB |
30c1193 | 6.27 MiB | 7.20 MiB | 958.74 KiB |
e66e71e | 6.06 MiB | 7.09 MiB | 1.03 MiB |
62dde43 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
5aab4c5 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
5e8d2b3 | 6.15 MiB | 7.13 MiB | 1000.11 KiB |
Previous results on branch: fix/parse-platform-exception-from-details
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e04ec9 | 380.18 ms | 440.74 ms | 60.56 ms |
40ccaf4 | 394.53 ms | 457.10 ms | 62.57 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e04ec9 | 6.33 MiB | 7.30 MiB | 992.48 KiB |
40ccaf4 | 6.33 MiB | 7.30 MiB | 992.48 KiB |
denrase
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
May 13, 2024 13:33
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
==========================================
- Coverage 95.30% 95.25% -0.06%
==========================================
Files 54 54
Lines 1789 1791 +2
==========================================
+ Hits 1705 1706 +1
- Misses 84 85 +1 ☔ View full report in Codecov by Sentry. |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fe4aa56 | 1248.82 ms | 1261.35 ms | 12.53 ms |
955541a | 1230.22 ms | 1252.96 ms | 22.73 ms |
5aba417 | 1265.31 ms | 1287.90 ms | 22.59 ms |
0be962b | 1264.10 ms | 1281.16 ms | 17.06 ms |
1cdcacf | 1208.35 ms | 1235.13 ms | 26.77 ms |
b8562d0 | 1249.92 ms | 1267.56 ms | 17.64 ms |
9928a74 | 1249.98 ms | 1269.08 ms | 19.10 ms |
3de8b9b | 1234.22 ms | 1251.94 ms | 17.72 ms |
a609134 | 1254.50 ms | 1265.08 ms | 10.58 ms |
2331d89 | 1260.86 ms | 1281.24 ms | 20.39 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fe4aa56 | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
955541a | 8.28 MiB | 9.34 MiB | 1.06 MiB |
5aba417 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
0be962b | 8.10 MiB | 9.16 MiB | 1.07 MiB |
1cdcacf | 8.32 MiB | 9.39 MiB | 1.06 MiB |
b8562d0 | 8.33 MiB | 9.54 MiB | 1.22 MiB |
9928a74 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
3de8b9b | 8.28 MiB | 9.34 MiB | 1.06 MiB |
a609134 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
2331d89 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
Previous results on branch: fix/parse-platform-exception-from-details
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e04ec9 | 1234.96 ms | 1265.67 ms | 30.72 ms |
40ccaf4 | 1249.88 ms | 1270.68 ms | 20.80 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e04ec9 | 8.32 MiB | 9.52 MiB | 1.20 MiB |
40ccaf4 | 8.32 MiB | 9.52 MiB | 1.20 MiB |
Here's some platform exceptions:
A lot of the times the stacktrace is reported properly in the |
buenaflor
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Parse platform exception from details, not message.
💡 Motivation and Context
Closes #2041
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled