-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flutter replay for Android [waiting for upstream SDK release] #2032
base: main
Are you sure you want to change the base?
Conversation
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
- Coverage 95.30% 92.69% -2.62%
==========================================
Files 54 60 +6
Lines 1789 1970 +181
==========================================
+ Hits 1705 1826 +121
- Misses 84 144 +60 ☔ View full report in Codecov by Sentry. |
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterReplayRecorder.kt
Outdated
Show resolved
Hide resolved
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterReplayRecorder.kt
Show resolved
Hide resolved
c6eb9f1
to
5876a6b
Compare
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterReplayRecorder.kt
Show resolved
Hide resolved
5876a6b
to
c50c1ca
Compare
c50c1ca
to
f3057cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, will do another round of review - cool stuff!
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
Sorry for the delay, will look over it once more tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 🚀
📜 Description
Adds session replay support for Flutter (Android)
💡 Motivation and Context
💚 How did you test it?
Unit tests and manually
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps