Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move progress bar code into submodule #2042

Closed
wants to merge 2 commits into from

Conversation

szokeasaurusrex
Copy link
Member

Moving the progress bar code into a submodule will allow us to move the ProgressBarMode code from the api module next to the progress bar code. I will create a separate PR to move the ProgressBarMode code

Moving the progress module into a directory will allow us to move other progress-bar related code into the same directory. For example, we can move the progress bar mode code from API to this new directory.
@loewenheim
Copy link
Contributor

I'm not sure why moving ProgressBarMode here requires the creation of a bar module? Without the further change, this just leaves the progress module empty. Is there a reason all the progress bar code can't be in one file?

@szokeasaurusrex
Copy link
Member Author

szokeasaurusrex commented Apr 24, 2024

@loewenheim I made those changes in #2041, which depends on this PR, and which it seems you already approved. I had forgotten to request review on this PR at the same time, sorry if that caused any confusion!

@loewenheim
Copy link
Contributor

(I assume you mean #2041)

Right. Looking at both these PRs together, I think the progress module is small enough (around 100 lines) that splitting it into bar and mode modules is unnecessary, but it's up to you.

Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@szokeasaurusrex
Copy link
Member Author

Right. Looking at both these PRs together, I think the progress module is small enough (around 100 lines) that splitting it into bar and mode modules is unnecessary, but it's up to you.

Okay, then I will have everything in a single module. I changed #2041 accordingly, and will close this PR in favor of #2041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants