-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create README-zh.md #2693
base: master
Are you sure you want to change the base?
Create README-zh.md #2693
Conversation
Add Chinese readme file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@beyondverage0908 @RayWP If we merge this, can we count on you to help us keep it up-to-date as we make other README changes? |
We'll also need to get this passing CI, looks like maybe trailing whitespace? |
Hrm, I think you posted then deleted @RayWP? 🤔 Either way, I'm good to merge this once we clean up the pre-commit check. |
https://github.com/getsentry/self-hosted/actions/runs/7571747446/job/20619977561?pr=2693#step:4:4039 Spurious? 🤔 Doesn't fee like it, same in the others: https://github.com/getsentry/self-hosted/actions/runs/7571747446/job/20619978008?pr=2693#step:4:3841 Random instance of the word "memcache" crossing my radar at roughly the same time ... probably not directly related, but maybe? |
Rerunning failures ... |
Still failing, need to dig deeper. |
@chadwhitacre maybe this will fix the issue? |
tests are now passing, precommit needs to be fixed though |
Add Chinese readme file
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.