Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Retain errors if send fails #52

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

toolboxash
Copy link

Original feature merged from sblepa with tests fixed.

@emartynov
Copy link

Thanks a lot for pull request. Can I comment changes?

One general comment - default implementation is not saving data for failed request. So every developer should implement same himself.

@toolboxash
Copy link
Author

Did you need me to do anything?

On 31 Mar 2015, at 08:26, Eugen Martynov notifications@github.com wrote:

Thanks a lot for pull request. Can I comment changes?

One general comment - default implementation is not saving data for failed request. So every developer should implement same himself.


Reply to this email directly or view it on GitHub #52 (comment).

@emartynov
Copy link

I don't know how Raven people are handling comments for pull request. It is up to you but I would implement changes if you agree with them.

@asbjornu
Copy link
Contributor

@emartynov You're free to make a fork of @toolboxash's code, make the changes you'd like, and submit your own pull request. If @toolboxash agrees with your changes, we can merge your pull request and close this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants