Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Assets.php #1687

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Update Assets.php #1687

wants to merge 3 commits into from

Commits on Oct 12, 2017

  1. Update Assets.php

    This is a small addition to the previous change. 
    This allows to have multiple type on inlined js. Without this change, if you have something like
    ```
    {% do assets.addInlineJs('Hello', 100,'', "somespecialtype") %}
    {% do assets.addInlineJs('Good Morning', 100,'', "anothertype") %}
    {% do assets.addInlineJs('Goodbye', 100,'') %} // regular inlined js
    {% do assets.addInlineJs('Bonjour', 100,'') %} // regular inlined js
    ```
    
    It will be rendered like this:
    
    ```
    <script type="somespecialtype">
    Hello 
    Good Morning
    Goodbye
    Bonjour
    </script>
    ```
    
    With this fix, it should display 
    ```
    <script type="anothertype">
    Good Morning
    </script>
    
    <script type="somespecialtype">
    Hello
    </script>
    
    // These two inlined js has no type specified, so we can group them on the same tag
    <script>
    Bonjour 
    Goodbye
    </script>
    ```
    paulmassen committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    2a97b87 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2017

  1. Update assets.php

    as per recommendation
    paulmassen committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    e5e858d View commit details
    Browse the repository at this point in the history
  2. Update Assets.php

    paulmassen committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    5cd745f View commit details
    Browse the repository at this point in the history