Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new languages and options #68

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

new languages and options #68

wants to merge 8 commits into from

Conversation

evehne
Copy link

@evehne evehne commented Nov 24, 2017

options @ ./blueprints.yaml

  • add capacity to enable/disable "grav sign" in side bar
  • move all text as languages constants
  • add tab navigation (global [plugin options] / view [frontend options] / github [github options])

languages

  • removed ./languages.yaml -> one file for translations = problems
  • ./languages/
  • ./languages/en.yaml as English translation
  • ./languages/fr.yaml as French translation

Copy link
Member

@rhukster rhukster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a great improvement. I do have one concern about the current langs tho. If you can sort that i'll gladly merge.

THEME_LEARN2_CLEAR_HISTORY: Clear History
THEME_LEARN2_BUILT_WITH_GRAV: Built with <a href="http://getgrav.org">Grav</a> - The Modern Flat File CMS
THEME_LEARN2_SEARCH_DOCUMENTATION: Search Documentation
cn:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are losing support for some languages by simply deleting this file and replacing it with en, fr. You should at least create files for these languages with only these few translations in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants