Bump the minimum iOS version #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radazzouz
requested review from
phatblat,
konstantinbe,
bplattenburg,
magicwave and
ErikEverson
bplattenburg
approved these changes
May 8, 2024
phatblat
reviewed
May 8, 2024
| @@ -4,7 +4,7 @@ import PackageDescription | |||
|
|
|||
| let package = Package( | |||
| name: "Ditto", | |||
| platforms: [ .iOS(.v11), .macOS(.v11) ], | |||
| platforms: [ .iOS(.v14), .macOS(.v11) ], | |||
There was a problem hiding this comment.
This package manifest is actually copied from cocoa/DittoSwiftPackage.template/Package.swift as part of the release process so we should update that.
There was a problem hiding this comment.
Great call, @phatblat! I landed https://github.com/getditto/ditto/pull/12825.
There was a problem hiding this comment.
I am leaving this PR open so we can test the change, but we should close it (not merge it) once we're done testing.
|
https://github.com/getditto/ditto/pull/12825 is now merged! This PR is no longer needed since our next minor release will automatically do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Since SDK version 4.5, the Swift SDK requires iOS 14 or later, but we have omitted updating it in this repo.
N.B. There's no need to update the macOS version since it hasn't changed.
Additional Context
See this proposal for more details.
Also, see this Slack discussion
How to Test:
DittoSwiftPackage