Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate repository fields in config #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joneshf
Copy link
Contributor

@joneshf joneshf commented Jul 16, 2022

We want to change these fields to be smarter in the future.

These fields are all fine for the case where there's only an origin repo
that is being worked against. Once we get to wanting to support an
upstream repo for a fork, these fields start to take on a bit more
logic. In an effort to make that step a bit easier, we encapuslate the
direct access to these fields behind functions where that logic can
exist.

This is pre-work for #80 that is
spun out of #106.

Test Plan:
There should be no actual changes here. It should be enough to run
cargo test and see no failures.

Created using spr 1.3.4-beta.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant