Use PaginationTrigger to avoid loading all org members #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5-beta.1
jwatzman
commented
Sep 27, 2023
| <UserCount>{users.length}</UserCount> | ||
| <UserCount> | ||
| {orgMembers.orgMembers.length} | ||
| {orgMembers.hasMore ? '+' : ''} |
There was a problem hiding this comment.
@yeo-yeo this is IMO an omission in the new API -- we should send a total count so you know how many before you paginate through. @maylynn-ng is working on the first API we have now which combines paginated and non-paginated data, so we should follow the pattern there.
yeo-yeo
approved these changes
Sep 29, 2023
|
Having accepted, I've also just commented on https://github.com/getcord/clack/pull/67/files#r1341231319 that this might cause problems in that diff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use this handy component to auto-paginate the members modal,
improving #63. A bit of plumbing to hand the entire
OrgMembersDatadown.
It does say "More messages available", not "users", but can fix that up
at some point later.
Test Plan:
Load
#what-the-quack. See10+users. Click to open modal. Opens,more users paginate in. Modify the
PaginationTriggerto not auto-loadon visible, see button, click to see more users.