[GEOT-7570] Small features that cross the dateline may be interpreted as preflipped #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaime
requested changes
May 14, 2024
| /** | ||
| * Builds a new wrapper | ||
| * | ||
| * @param wrapLimit Subsequent coordinates whose X differ from more than {@code wrapLimit} are | ||
| * supposed to be wrapping the dateline and need to be offsetted | ||
| * @param offset The offset to be applied to coordinates to unwrap them | ||
| * @param mt The math transform to use to detect the wrapping | ||
| * @param wrapOnY If true, the wrapping is supposed to happen on the Y axis, otherwise on the X | ||
| * @param isPreFlipped If true, the coordinates are already flipped, so the wrapping is supposed |
There was a problem hiding this comment.
Suggested change
| * @param isPreFlipped If true, the coordinates are already flipped, so the wrapping is supposed | |
| * @param isPreFlipped If true, the coordinates are already flipped, so the wrapping is supposed |
Supposed? 🤣
Comment on lines
55
to
59
| /** The tolerance to consider a geometry without touching both datelines */ | ||
| public static final double DATELINE_PROXIMITY_TOLERANCE = 1.99572; |
There was a problem hiding this comment.
Comment that it was obtained by trial and error.
Comment on lines
+262
to
+266
| * In some cases the geometry is preflipped due to coordinate order and proximity to the | ||
| * dateline |
There was a problem hiding this comment.
Write an example, 3 points polygon or 2 points line that would show what pre-flipped means.
… as preflipped removed longestline filter cleanup added PR comments
turingtestfail
force-pushed
the
GEOT-7570-dateline-preflipped
branch
from
4394c8a
to
f477874
Compare
aaime
added
backport 30.x
aaime
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed longestline filter
cleanup
Checklist
mainbranch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOT-XYZW] Title of the Jira ticket.