Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOT-7432] Inclusive comparison for DWithin filtering #4468

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjornharrtell
Copy link
Contributor

@bjornharrtell bjornharrtell commented Sep 5, 2023

GEOT-7432 Powered by Pull Request Badge

See https://osgeo-org.atlassian.net/jira/software/c/projects/GEOT/issues/GEOT-7432

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

@aaime
Copy link
Member

aaime commented Sep 18, 2023

I can't find a clear indication of whether distance should < or <=, but the in-memory implementation uses JTS, which in turn uses "<=". So the change seems legit. However, as usual, we need a test 🤣

Also, please don't remove the checklist, fill it instead (just added it back).

@bjornharrtell
Copy link
Contributor Author

Thanks @aaime I wasn't sure of the correctness here but since you agree I will continue working on this and add a test.

@aaime
Copy link
Member

aaime commented Dec 11, 2023

@bjornharrtell while you're dabbling on GeoTools code could you also add a test for this one?

@bjornharrtell
Copy link
Contributor Author

@aaime I'll try!

Copy link

stale bot commented Mar 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 12, 2024
@bjornharrtell
Copy link
Contributor Author

I did try some weeks ago but was unable to get online tests to work and had some other development setup issues, unfortunately. I'm willing to make another attempt at some point in the future.

@mprins mprins marked this pull request as draft March 12, 2024 12:43
@stale stale bot removed the stale label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants