Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOT-7234] Implement #getOptimizedBounds(...) in SQLServerDialect #4293

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mprins
Copy link
Member

@mprins mprins commented May 22, 2023

GEOT-7234 Powered by Pull Request Badge

reopening #4038 in a new PR; I missed the @Stale comments due to holidays

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

@mprins mprins force-pushed the GEOT-7234_SQLServerDialect#getOptimizedBounds branch from d7d32af to 25e6223 Compare July 20, 2023 08:14
@mprins mprins force-pushed the GEOT-7234_SQLServerDialect#getOptimizedBounds branch from 25e6223 to 9e68733 Compare August 25, 2023 08:36
@mprins mprins force-pushed the GEOT-7234_SQLServerDialect#getOptimizedBounds branch from 9e68733 to eb26e5b Compare November 6, 2023 15:26
@mprins mprins force-pushed the GEOT-7234_SQLServerDialect#getOptimizedBounds branch from eb26e5b to 8ad419f Compare November 17, 2023 09:30
@mprins mprins force-pushed the GEOT-7234_SQLServerDialect#getOptimizedBounds branch 2 times, most recently from 7fdf448 to 5e3010b Compare January 4, 2024 09:14
@mprins mprins force-pushed the GEOT-7234_SQLServerDialect#getOptimizedBounds branch from 5e3010b to 4e410e3 Compare February 3, 2024 11:45
@jodygarnett
Copy link
Member

This is a draft from last year, and predates the API change. Is it something you wish to pursue?

@mprins
Copy link
Member Author

mprins commented Mar 4, 2024

@jodygarnett I will, when I get the time, however looking into a different approach that avoids the possible table scan and queries the spatial index directly.
This branch is in fact up-to-date with the API changes

@mprins mprins force-pushed the GEOT-7234_SQLServerDialect#getOptimizedBounds branch from 4e410e3 to dd916c4 Compare March 22, 2024 13:02
@mprins mprins force-pushed the GEOT-7234_SQLServerDialect#getOptimizedBounds branch from dd916c4 to f26a1d1 Compare April 27, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants