Calculate resolution correctly for rotated rasters #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@constantinius Could you please take a look at this? Having this and #414 merged and published would help in adding support for skewed or rotated GeoTIFFs in OpenLayers (openlayers/openlayers#15402). |
|
@constantinius Now that #414 is merged, would you please also consider this pull request? Then we could proceed fixing openlayers/openlayers#15402. Thanks in advance! |
|
@ahocevar done. Unfortunately the CI pipeline seems broken, not sure what is the issue. |
Merged
|
@constantinius It's not a CI issue, it's a syntax error in the code. Sorry for having recommended to merge this pull request without recognising that. I created a fix in #418. |
|
@ahocevar This is now published in 2.1.3 |
|
Thanks, @constantinius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #403 where the Y axis resolution should have been negated