[GEOS-11040] Fix serviceInfo missing in FeatureService and TileService classes #7620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaime
reviewed
May 10, 2024
| @@ -199,6 +199,12 @@ public WFSInfo getService() { | |||
| return geoServer.getService(WFSInfo.class); | |||
| } | |||
|
|
|||
| @SuppressWarnings("unused") | |||
| public WFSInfo getServiceInfo() { | |||
There was a problem hiding this comment.
Oh interesting... yeah, that callback uses reflection to access the info form the service object itself!
One day we should switch to just having an interface for it (ServiceInfoProvider or something similar).
aaime
added
backport 2.24.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve frequent log messages generated by DisabledServiceCheck class
Referenced JIRA issue: GEOS-11040
Checklist
mainbranch (backports managed later; ignore for branch specific issues).