Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve challenge 06 setup #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs: improve challenge 06 setup #3

wants to merge 2 commits into from

Conversation

heddendorp
Copy link
Contributor

No description provided.

Lukas Heddendorp added 2 commits December 7, 2018 14:08
THis branch adds new cdk dependencies and should be installed
@georgiee georgiee self-requested a review December 7, 2018 13:32
Copy link
Owner

@georgiee georgiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you head problems with CDK? It's in the package.json from the very beginning. I don't know what happened. I would suggest you mention the error — so anyone with the same problem can run npm install while it should work for most people. Can you change the PR? Thanks a lot for spotting this.

See that branch from the first challenge - it's there ?

https://github.com/georgiee/skipbo-angular/blob/7f0d8ade67009dc3983b846dfc3cf675c1132053/package.json#L16

@heddendorp
Copy link
Contributor Author

I've gone through the branches again and found a second thing.
rxjs-spy is not found in the start branch and even though the cdk is already present cdkDropListDisabled was not available until #13722 and version 7.1 => cause of the crash when not running npm install

Additionally i would consider only having the src folder in a sub module to make dependency management easier or going even further, only have a WorkshopModule and have the frame application be static through the workshop challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants