Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record view / Focus on organisation fix #8040

Merged
merged 1 commit into from
May 17, 2024
Merged

Record view / Focus on organisation fix #8040

merged 1 commit into from
May 17, 2024

Conversation

fxprunayre
Copy link
Member

Since organisation name is an object field use the default property to filter on (the search was made on OrgForResource).

image

The fix may not work when organisation name are multilingual. To be improved.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Vlaanderen

Since organisation name is an object field use the default property to filter on.

The fix may not work when organisation name are multilingual. To be improved.
@fxprunayre fxprunayre added this to the 4.4.5 milestone May 15, 2024
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@joachimnielandt joachimnielandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@fxprunayre fxprunayre merged commit ec89928 into main May 17, 2024
9 checks passed
@fxprunayre fxprunayre deleted the 44-focusonorg branch May 17, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants