Fix + add argument to pad for pytorch backend #1997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
In the pytroch backend, the argument used for padding values was "constant_value". However, the naming in jax and numpy is constant_values. See https://numpy.org/doc/stable/reference/generated/numpy.pad.html
and https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.pad.html. I also added passing on the "mode" argument, which is supported by pytorch.
Issue
This patch ensures that passing "constant_values" is compatible with all backends.
Additional context