-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grassmannian manifold visualization for 3D #1804
base: main
Are you sure you want to change the base?
Conversation
Jacqueskim
commented
Jan 29, 2023
•
edited
edited
- Add a test case for grassmannian manifold
- Follow the docstring guidelines
- Pass the linting test for Grassmannian.py and test file
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #1804 +/- ##
==========================================
- Coverage 91.50% 90.87% -0.62%
==========================================
Files 136 137 +1
Lines 13738 13963 +225
==========================================
+ Hits 12569 12688 +119
- Misses 1169 1275 +106
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address my comments from Christine's PR (applied to this PR) and resubmit.