Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grassmannian manifold visualization for 3D #1804

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

Jacqueskim
Copy link
Collaborator

@Jacqueskim Jacqueskim commented Jan 29, 2023

  • Add a test case for grassmannian manifold
  • Follow the docstring guidelines
  • Pass the linting test for Grassmannian.py and test file

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #1804 (e414579) into master (6f37453) will decrease coverage by 0.62%.
The diff coverage is 52.00%.

@@            Coverage Diff             @@
##           master    #1804      +/-   ##
==========================================
- Coverage   91.50%   90.87%   -0.62%     
==========================================
  Files         136      137       +1     
  Lines       13738    13963     +225     
==========================================
+ Hits        12569    12688     +119     
- Misses       1169     1275     +106     
Flag Coverage Δ
autograd 86.82% <52.00%> (-0.60%) ⬇️
numpy 86.48% <52.00%> (-0.62%) ⬇️
pytorch 80.02% <52.00%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/visualization/grassmannian.py 52.00% <52.00%> (ø)
geomstats/information_geometry/dirichlet.py 93.69% <0.00%> (+0.36%) ⬆️
geomstats/learning/expectation_maximization.py 81.01% <0.00%> (+0.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jacqueskim Jacqueskim changed the title test linting Grassmannian manifold visualization for 3D Jan 29, 2023
Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address my comments from Christine's PR (applied to this PR) and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants