Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better vectorizations of jacobian and hessian in the autodiff backends #1724

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ninamiolane
Copy link
Collaborator

@ninamiolane ninamiolane commented Oct 26, 2022

This PR will unify the shapes of jacobians and hessians computed across backends, to enhance the readability while using these functions in the pullback metric file.

Checklist

  • My pull request has a clear and explanatory title.
  • If neccessary, my code is vectorized.
  • I have added apropriate unit tests.
  • I have made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My PR follows geomstats coding style and API.
  • My code is properly documented and I made sure the documentation renders properly. (Link)
  • I have linked to issues and PRs that are relevant to this PR.

Description

Issue

Additional context

@ninamiolane ninamiolane marked this pull request as draft October 26, 2022 16:36
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #1724 (f6765b0) into master (2598d50) will decrease coverage by 2.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1724      +/-   ##
==========================================
- Coverage   90.12%   87.21%   -2.90%     
==========================================
  Files         121      115       -6     
  Lines       12060    11390     -670     
==========================================
- Hits        10868     9933     -935     
- Misses       1192     1457     +265     
Flag Coverage Δ
numpy 87.21% <ø> (+0.05%) ⬆️
pytorch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geomstats/geometry/pullback_metric.py 26.52% <0.00%> (-64.08%) ⬇️
geomstats/geometry/sub_riemannian_metric.py 43.40% <0.00%> (-50.94%) ⬇️
geomstats/learning/geodesic_regression.py 31.17% <0.00%> (-48.70%) ⬇️
...eomstats/information_geometry/fisher_rao_metric.py 23.34% <0.00%> (-46.66%) ⬇️
geomstats/geometry/fiber_bundle.py 66.67% <0.00%> (-28.20%) ⬇️
geomstats/geometry/connection.py 75.49% <0.00%> (-17.41%) ⬇️
geomstats/geometry/riemannian_metric.py 78.27% <0.00%> (-6.52%) ⬇️
geomstats/information_geometry/gamma.py 53.34% <0.00%> (-4.12%) ⬇️
geomstats/learning/geometric_median.py 92.31% <0.00%> (-2.56%) ⬇️
geomstats/information_geometry/normal.py 91.53% <0.00%> (-1.69%) ⬇️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant