An implementation of coupled bcs. #460
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Think this can actually be reimplemented in a considerably simpler way but I would like to add a test to this version first. This may break current tests as it changes the default boundary condition logic (it is no longer possible to just set the bc type based on what it is not because there are more than two types of bc now).
cianwilson
commented
Jun 13, 2023
cianwilson
commented
Jun 13, 2023
This allows generic scalar fields to be output which have a length of at least 5 (not just 4).
This may break tests that rely on the old defaults.
This just runs for 2 timesteps and checks that the shell slices produced match the expected values on 2 coupled fields (1 temperature, 1 chi, both coupled to another chi).
cianwilson
commented
Jun 15, 2023
src/Physics/BoundaryConditions.F90
Outdated
| Real*8 :: dTdr_chi_coeff_bottom(1:n_scalar_max) = 0.0d0 | ||
| Real*8 :: dTdr_dchidr_coeff_bottom(1:n_scalar_max) = 0.0d0 | ||
| Real*8 :: dTdr_T_coeff_bottom = 0.0d0 | ||
|
|
||
| Real*8 :: chi_a_Bottom(1:n_scalar_max) = 1.0d0 |
|
Need to set this up to restore the old defaults if no other bc is set |
But unclear what to do about the default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently just a draft PR! Please do not merge.
I think this initial implementation can actually be reimplemented in a considerably simpler way but I would like to add a test to this version first.
This may break current tests as it changes the default boundary condition logic (it is no longer possible to just set the bc type based on what it is not because there are more than two types of bc now).