Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/python-language-server: Relax dev-python/jedi dependency #20281

Closed

Conversation

mattst88
Copy link
Contributor

@mattst88 mattst88 commented Apr 6, 2021

jedi-0.18.0 works, at least. (FIXME: looks like it causes two tests to fail?)

See palantir/python-language-server#918

Also add Python 3.9 support. (FIXME: looks like it causes one test to fail?)

Signed-off-by: Matt Turner mattst88@gentoo.org

jedi-0.18.0 works, at least.

See palantir/python-language-server#918

Also add Python 3.9 support.

Signed-off-by: Matt Turner <mattst88@gentoo.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mattst88
Areas affected: ebuilds
Packages affected: dev-python/python-language-server

dev-python/python-language-server: @AndrewAmmerlaan, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 6, 2021
@mattst88
Copy link
Contributor Author

mattst88 commented Apr 6, 2021

A quick check indicates that

FAILED test/plugins/test_symbols.py::test_symbols - assert 0 == 5
FAILED test/plugins/test_symbols.py::test_symbols_all_scopes - assert 0 == 8

fail with jedi-0.18.0.

And

FAILED test/plugins/test_folding.py::test_folding - AssertionError: assert [{'endLine': 6, 'startLine': 1},\n {'endLine': 3, 'startLine': 2},\n {'endLine': 6, 'startLine': 5},...

fail with Python 3.9.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-04-06 19:19 UTC
Newest commit scanned: fe493d6
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/e1bce23fdb/output.html#dev-python/python-language-server

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e1bce23fdb/output.html

@AndrewAmmerlaan
Copy link
Member

Hmm, I'm getting a different error with py3.7 and jedi-0.17.2-r1 that I wasn't getting before:

FAILED test/plugins/test_completion.py::test_snippet_parsing - AssertionError: assert 'logical_and($0)' == 'logical_and(${1:x1}, ${2:x2})$0'
FAILED test/plugins/test_hover.py::test_numpy_hover - IndexError: string index out of range

@AndrewAmmerlaan
Copy link
Member

Found a patch for test_folding.py in the Arch repository: https://github.com/archlinux/svntogit-community/blob/packages/python-language-server/trunk/fix-test.patch

@AndrewAmmerlaan
Copy link
Member

Made a PR with some patches that I collected here and there. For me this works with py3.9 and jedi-0.18.0: #20284

@mattst88 mattst88 closed this Apr 6, 2021
@mattst88 mattst88 deleted the python-language-server-python-3.9 branch July 22, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants