Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home #1784

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

Fix home #1784

wants to merge 61 commits into from

Conversation

hgouraud
Copy link
Collaborator

@hgouraud hgouraud commented Apr 19, 2024 •
edited

use Perso.interp_templ rather than Util.open_etc_file
The latter does not interpret (or remember) the %let commands found in the template file.
This modification removes multiple errors appearing when the home.txt template file was called (undefined rng, random).
The fix has not been applied to Notes display as the base parameter is not available in this context.
For another case, the use of Perso.interp_templ created a dependency cycle!

@a2line
Copy link
Collaborator

a2line commented Apr 20, 2024

Première remarque : j'ai des erreurs à la pelle en visiteur quand je ne suis pas connecté, alors que ça a l'air fonctionnel en magicien.

@hgouraud hgouraud force-pushed the fix-home branch 5 times, most recently from 27ffe10 to ba02357 Compare April 21, 2024 16:49
@hgouraud hgouraud force-pushed the fix-home branch 3 times, most recently from c9c07bc to b74350e Compare April 22, 2024 15:00
@michelmno
Copy link
Contributor

I tested last update of this PR with cid b74350e, and for some individual with no parents, the error message is switching from unbound var "sosa_ref.key" already tracked by issue #1778 to warning must test "has_parents" as extracted below.

[2024-04-23 05:50:43]: WARNING ./etc/modules/arbre_3gen_photo.txt 1447-1447: since v5.00, must test "has_parents" before using "mother"
[2024-04-23 05:50:48]: WARNING ./etc/modules/arbre_3gen_photo.txt 1385-1385: since v5.00, must test "has_parents" before using "father"

@hgouraud
Copy link
Collaborator Author

thanks for the test. fixed in c03357e

@hgouraud
Copy link
Collaborator Author

I tried to build some sort of regression test.
Can be expanded by adding additional commands
Look at test/run-GW-test.sh
You have to "personalize" according to your own base for some of the commands
Tell me what you think, and of possible improvements

@michelmno
Copy link
Contributor

I am suggesting a script change in michelmno@146f10a

@michelmno
Copy link
Contributor

first run with my DB is reporting:

[2024-04-24 07:34:28]: WARNING ./etc/buttons_dag.txt 6547-6548: since v5.00, must test "has_parents" before using "mother"
[2024-04-24 07:34:28]: WARNING ./etc/buttons_dag.txt 6564-6565: since v5.00, must test "has_parents" before using "mother"
[2024-04-24 07:34:28]: WARNING ./etc/buttons_dag.txt 8178-8179: since v5.00, must test "has_parents" before using "father"
[2024-04-24 07:34:28]: WARNING ./etc/buttons_dag.txt 8195-8196: since v5.00, must test "has_parents" before using "father"

@a2line
Copy link
Collaborator

a2line commented Apr 25, 2024

Pleas DON’T merge this PR. It is draft. I see a lot of mistakes to be fixed: double titles + double HTML headers on some .ml pages, menubar removed from carousel or not working at all on some old pages…

@michelmno
Copy link
Contributor

another error detected by run-GW-test.sh when invalid p value
http://localhost:2317/testbasefusionnee?m=FORUM&p=939
generating a critical error
[2024-04-26 08:46:51]: CRITICAL testbasefusionnee_w?m=FORUM&p=939 Invalid_argument("rseek_in")
Should I create a specific issue ?

@hgouraud
Copy link
Collaborator Author

hgouraud commented Apr 26, 2024 •
edited

yes. In fact no, this test is too base specific and the failure is inevitable.
I am pushing an update for run-GW-test following your modifications

@hgouraud hgouraud force-pushed the fix-home branch 4 times, most recently from c4fce82 to 007f027 Compare April 27, 2024 05:37
michelmno
michelmno reviewed Apr 28, 2024
View reviewed changes
test/run-GW-test.sh Outdated
crl "m=DEL_IND&i=$ID"
crl "m=MRG&i=$ID"
crl "m=CHG_EVT_IND_ORD&i=$ID"
crl "m=NV_FAM&i=$ID&f=$FID" # f=family_id is base specific!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume 'NV_FAM' is a typo, and should be 'INV_FAM' ?

michelmno
michelmno reviewed Apr 28, 2024
View reviewed changes
test/run-GW-test.sh Outdated
crl "m=CHG_EVT_IND_ORD&i=$ID"
crl "m=NV_FAM&i=$ID&f=$FID" # f=family_id is base specific!
crl "m=CHG_EVT_FAM_ORD&i=$FID&ip=$ID"
crl "m=DEL_FAM&i=$FID&ip=$FID$ID1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there missing characters in "&ip=$FID$ID1"

@michelmno
Copy link
Contributor

@hgouraud, I have new changes proposal for test/run-GW-test.sh in cid michelmno@e514bdd

Using it in my environment is reporting CRITICAL errors similar to issue #1788 when url parameters are not valid. But also some unbound failures as detailed in attached log
gwd_cgi_tst_error.extract.log

@a2line
change input type to password
3d6a9b7 
fix geneweb#1796
@a2line
better table header/tooltips
349a66d 
factorize header + place/date_popup functions in new table_utils subtemplate
fix headers for Firefox
simpler conditions for tooltip (wip)
@hgouraud
Copy link
Collaborator Author

@canonici, @ilankri, can you review? This is not WIP anymore

@a2line a2line force-pushed the fix-home branch 2 times, most recently from 6cdc569 to 529593c Compare May 22, 2024 05:20
@a2line
add a new ± button to prevent too quick high generation computing
2d88601 
* A new javascript function hide level btn > 12 (hard fixed atm,
but quite strange if max=13…), perhaps we need to remove the hiding "-" button,
it's not really usefull and can take a line for itself in some cases!
* Load once js function to copy the caution in title of every high v buttons.
* Hide the whole generation selector toolbar when not needed.
* Fix selected v in toolbar when evar.v > max_ancestor_level
and also e_v value for that case.

Also:
* Fix some rendering for some cases (fixing max_anc).
* Remove gen in title and fix left margin vs container-fluid.
* Fix him/her box, add a translation for neutral sex (iel in fr).
* Remove generation reminder (big numbers on left) if v<4.
* Add minimalist tooltips for each statistics.
* Rollback menubar default v= to 7 (was downgraded to 3).
@hgouraud hgouraud force-pushed the fix-home branch 3 times, most recently from 23f52d7 to e64ef9f Compare May 25, 2024 07:53
hgouraud and others added 15 commits May 28, 2024 23:23
@hgouraud @a2line
read #sep without date in family description
1a19156
@a2line
remove not found error on Windows
d9a5c3b
@a2line
few adjustement
ca58aec
@a2line
fix critical error because of missing %t
8bae977
@a2line
replace png by icons, better table
488f521
@a2line
add thousand separator function for template
9d30bf2
@a2line
add color by couple on ancestor picker, few fixes
a00a1ff 
* Ajust max_level, print max level on + button tooltip
* Add curlev+1 to print right box-drawing caracteres when individual has
descendant(s) at the hidden v+1 generation (not really estheatical but info was missing)
* Better anc/deslist icons for button bar and menubar.
* Add missing fa-rotate-90 in CSS!
* Fix left margin overlaping home.
@a2line
fix gradients, allow sorting by age
66d4d95 
* replace sort functions by a lone polyvalent function
* use order:-1 to sort descreasingly
* sort by age using julian day “ages”
* cleaner code
@hgouraud @a2line
test for existence of lexicon file. Avoid server crash
78799e1
@a2line
fix bad d'Aboville numerotation
2f4055e 
Notation is now the same as in destable
Add short title and use monospace font for notation
@a2line
add navigation tooltips, improve title and relation information display
850bf07 
fixes level 0 for desc1, also adapt title, add extend possibility to v+ button and remove useless total
display relation date in small, remove bold for married/italic for not_married, switch to X for not_married instead
move id/d-none for filters to the form itself to remove superflous line
center title in ancestor picker modal
@hgouraud @a2line
suppress link_to_welcome
a7c018b
@a2line
fix encoding
770e7bd 
my bad!
@a2line
use not-ocamlfind only if camlp5 version >= 8.03.00
dc7ad5a 
Add two new targets to patch/unpatch bin/ged2gwb/dune.in and ged2gwb.ml in
order that all various build work again. The perl regexps are compatible
between all OS (sed one are diverging between Unix and BSD). This modification
should be transparent for every usages. The "distrib" target has been reworked
a bit to allow “make fmt distrib” used on Github Action CI.
@a2line
prefer bold to white to improve readabilty when console background is…
e0c92eb 
… white

add a new simple “gwd” target to build only gwd executable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelmno michelmno michelmno requested changes

@a2line a2line Awaiting requested review from a2line

@canonici canonici Awaiting requested review from canonici

@ilankri ilankri Awaiting requested review from ilankri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hgouraud @a2line @michelmno