Advanced search: Refactor the code #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2024
|
where do we get Calendars.make? |
need Calendars |
Using the following identity:
```
if condition1 then
if condition2 then expression1 else expression2
else
if condition3 then expression1 else expression2
=
let condition = if condition1 then condition2 else condition3 in
if condition then expression1 else expression2
```
ilankri
force-pushed
the
gnt-adv-search-refacto
branch
from
78cea3d
to
0a4a5c4
Compare
|
@canonici Could you review this PR please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.