Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GNT] Advanced search #1593

Draft
wants to merge 58 commits into
base: gnt
Choose a base branch
from
Draft

[GNT] Advanced search #1593

wants to merge 58 commits into from

Conversation

Swrup
Copy link
Contributor

@Swrup Swrup commented Oct 2, 2023 •
edited

advanced search:

  • surname/first name search in surnames_aliases/first_names_aliases too
  • add search by aliases
  • add search by "other events" (all events)

(surnames/first_names)_aliases are put in surname/first_name index.
aliases have their own index.

Elie Canonici Merle and others added 30 commits September 29, 2023 11:38
refactoring advanced search
d6211f6
apply fmt
b4585f5
apply commmit 'move date functions out of Adef'
ee96754
apply type string
258e3fb
always use type for search_type
424604e
factorize event_search
aa23291
advanced search: search in aliases too
5c8359a 
  when searching by first_name/surname
wip: advanced search: add search by alias
cd20113
wip add math_other_events
0a161ed
replace ~values by ~places
bf4c48d
name param in do_compare
4e27786
wip change get to unit -> string list
4bb7e37
refacto place cmp wrapper
8849556
refacto wrapper hell
aad31ae
rm date_wrapper
7e10ca0
~df: change to use cdate_to_dmy_opt
45e9f70
use Date.dmy directly instead of Date.date
d32a34a
add default variable
3e740e6
do_compare: revert to single value; get -> value
717c6b8
use sex type asap
ea75bb7
add match_other_events_(place/date)
ed133e7
move surname_alias close to first_name_alias
805c448
wrap_match_name: revert to single value instead of list
1f9b632
fix match on empty list for _aliases
3d0ca3b
fix comment
4ff3935
? comment
6a4a450
clean up match_person
275696d
rm skip_fn/sn condition
97c049f
comment sosa_filter
ab52185
add todo?
f8793ed
swrup added 11 commits September 29, 2023 11:46
add todo?
45e08dd
comment small change in fold on patch
0d3de3b
add todo
7a60d44
put fn/sn aliases in patch
b3e651c 
  changed `p.surname` to be `p.surname :: p.surname_aliases` in some
  places.
  I do not understand completly what the changed code deals with.
wrap match_*_date to default if there is no dates
57aa0fe 
  This should not change search behavior because match_date already evaluate
  to default.
  But it should avoid unescessary checks
add other events to Or search
11c2131
rm @@
7e8b7e3
rename variable
a57edff
refacto get_event_field_name
ea7a862
more refacto
e7fa4ef
Or search: restrict search to event type
06edc3e
@Swrup Swrup mentioned this pull request Oct 2, 2023
Closed
@Swrup Swrup changed the title GNT Adv search [GNT] Adv search Oct 2, 2023
@Swrup Swrup changed the title [GNT] Adv search [GNT] Advanced search Oct 2, 2023
@Swrup Swrup marked this pull request as draft October 9, 2023 10:14
@ilankri ilankri self-assigned this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ilankri ilankri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Swrup @ilankri