partial_key: search_by_name then search (not exact) for surname, then…

[hgouraud]

in PartialKey,

• search-by-name
• if result is empty, try advanced_search with surname (entry data after first space). Possibility to ask for exact_surname=on

[a2line]

We need a tag/label “search”.

[michelmno]

• Is is a PR candidate for gw 7.1 ?
• Is there some previous issues related to those 11 commits ? or is a feature like change ?
• What are the use-cases to tests to validate code changes ?

[michelmno]

I did a local test with this branch (head at cid 4a9bfe0) from welcome page;
and was not able to search with firstname.occ in firstname field.
(same problem if firstname.occ surname in surname field)
This is a regression compared to master branch and previous releases.

[a2line]

the regression is last release over 6.07…

[hgouraud]

firstname.occ is not a legal firstname in the firstname field. This could be changed, but searching for all firstname.occ makes little sense. Last commit suppresses .occ
Searching for firstname.occ surname in the surname field works for me!

[michelmno]

Thank you for two added commits. Now I am able to use search as I previously used: a search with surname in surname field, AND firstname.occ in firstname field.
Sorry my previous comment was misleading, I do not want a search of firstname.occ alone.

[michelmno]

another difference with master branch I noticed (may be already known) searching for firstname lastname (either only in surname field or in surname and firstname fields) do not report all occurrences !
for example I have 20 occurrences of Didier Normand, but only 3 are listed as result of the search.

[hgouraud]

yes, there was a limit to 100 of the number of persons reported by advanced search.
This limit (in the search conetxt) is now suppressed
bab9acc..87904a8 better-search -> better-search

[michelmno]

yes, there was a limit to 100 of the number of persons reported by advanced search. This limit (in the search conetxt) is now suppressed bab9acc..87904a8 better-search -> better-search

ok for me with those changes

[michelmno]

Another problem with this branch (at cid b5a8c9b)

• try to search with surname and lastname fields with accented character; eg normand andré

• the search output report an error Not found: "andré normand"

• There is no such problem if lastname and surname specified together in surname field. andré normand

• No such problem either with current master branch (cid 19918c0)

if useful, a git bisect identify second cid 0edf59b of the branch as source of the problem.

[hgouraud]

problem corrected by last commit

[michelmno]

problem corrected by last commit

Thank you for this update,
But two other searching problems on welcome page, with this branch at cid c281bea, that are not present with master branch cid 19918c0 or previous geneweb v7.

• failure if search surname and composite firstname (eg thomas and jean baptiste)
• failure if search surname and "alternate firstname" (eg thomas and constance francoise marie victoire)

[michelmno]

And another one also failing with this branch and not master or geneweb v7:

• search a surname with prefix and a simple firstname (eg o'brien and edouard)
  (good search if only this same surname with prefix in surname field but no firstname field set)

[hgouraud]

This PR needs a little bit of additional work. Will look into it