-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gedcom: _GW_CHRONICLE tag #1495
Draft
Swrup
wants to merge
119
commits into
integration-master-gnt
Choose a base branch
from
chronicle
base: integration-master-gnt
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of collision with a read operation
This reverts commit 3666923. Because of wiki syntax we need to insert "<br>" in notes so it looks like in other software... This is bad and should not be done like this. User data should not be modified. This is buggy on export/import cycle in .gw/.ged
…dle erased persons and families when traversing the base
zapashcanon
reviewed
Jun 26, 2023
@@ -189,18 +189,25 @@ let rec display_note_aux opts tagn s len i = | |||
(oc opts) (Buffer.contents b); | |||
display_note_aux opts tagn s (len + 1) (!j + 1) | |||
|
|||
let display_note opts ?source_page tagn s = | |||
let display_note opts tagn s = | |||
if opts.Gwexport.notes && s <> "" then ( | |||
let tag = Printf.sprintf "%d NOTE " tagn in | |||
Printf.ksprintf (oc opts) "%s" tag; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(oc opts) tag;
zapashcanon
reviewed
Jun 26, 2023
if opts.Gwexport.notes then | ||
(let tagn = 1 in | ||
let tag = Printf.sprintf "%d _GW_CHRONICLE\n" tagn in | ||
Printf.ksprintf (oc opts) "%s" tag; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(oc opts) tag;
zapashcanon
reviewed
Jun 26, 2023
if content <> "" then ( | ||
Printf.ksprintf (oc opts) "%d FILE %s\n" (tagn + 1) filename; | ||
let tag = Printf.sprintf "%d NOTE " (tagn + 2) in | ||
Printf.ksprintf (oc opts) "%s" tag; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(oc opts) tag;
canonici
force-pushed
the
integration-master-gnt
branch
from
August 3, 2023 10:40
877229b
to
ed2b8cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #1464
TODO: import chronicle, or at least the index page