Witness notes #1481

canonici · 2023-05-11T10:29:33Z

Support for witness notes in geneweb

a2line · 2023-05-14T18:09:29Z

as make distrib still lacks from Github CI here is what I have for this branch on Windows

ocaml ./configure.ml --sosa-legacy --gwdb-legacy --release

$ make distrib
cat dune-workspace.in | sed  -e "s/%%%DUNE_PROFILE%%%/release/g" > dune-workspace
Last commit is 4dfc601d2 (2023-05-12).
Generating hd/etc/version.txt… Done.
Generating lib/dune… Done.
Generating lib/gwdb/dune… Done.
Generating lib/core/dune… Done.
Generating lib/util/dune… Done.
Generating lib/system_util/dune… Done.
Generating lib/gwdb-legacy/dune… Done.
Generating lib/gwdb-versioned/dune… Done.
Generating benchmark/dune… Done.
Generating bin/connex/dune… Done.
Generating bin/consang/dune… Done.
Generating bin/fixbase/dune… Done.
Generating bin/ged2gwb/dune… Done.
Generating bin/gwb2ged/dune… Done.
Generating bin/gwc/dune… Done.
Generating bin/gwd/dune… Done.
Generating bin/gwdiff/dune… Done.
Generating bin/gwgc/dune… Done.
Generating bin/gwrepl/dune… Done.
Generating bin/gwu/dune… Done.
Generating bin/setup/dune… Done.
Generating bin/update_nldb/dune… Done.
Generating test/dune… Done.
rm -f -r distribution
dune build -p geneweb --profile release
File "lib/gwdb-legacy/dune", line 19, characters 4-15:
19 |     gwdb_driver
         ^^^^^^^^^^^
Error: The following modules are implementations of virtual modules:
- Gwdb_driver
They cannot have their own interface files.
make: *** [Makefile:128: distrib] Error 1

Is --gwdb-legacy deprecated or broken?

a2line · 2023-05-14T18:20:21Z

Without gwdb-legacy it falls back to gwdb-versionned and seems to ask for syslog (I didn't use --syslog in configure.ml)

A2@D /cygdrive/c/gw
$ ocaml ./configure.ml --release --sosa-legacy

A2@D /cygdrive/c/gw
$ make distrib
cat dune-workspace.in | sed  -e "s/%%%DUNE_PROFILE%%%/release/g" > dune-workspace
Last commit is 4dfc601d2 (2023-05-12).
Generating hd/etc/version.txt… Done.
Generating lib/dune… Done.
Generating lib/gwdb/dune… Done.
Generating lib/core/dune… Done.
Generating lib/util/dune… Done.
Generating lib/system_util/dune… Done.
Generating lib/gwdb-legacy/dune… Done.
Generating lib/gwdb-versioned/dune… Done.
Generating benchmark/dune… Done.
Generating bin/connex/dune… Done.
Generating bin/consang/dune… Done.
Generating bin/fixbase/dune… Done.
Generating bin/ged2gwb/dune… Done.
Generating bin/gwb2ged/dune… Done.
Generating bin/gwc/dune… Done.
Generating bin/gwd/dune… Done.
Generating bin/gwdiff/dune… Done.
Generating bin/gwgc/dune… Done.
Generating bin/gwrepl/dune… Done.
Generating bin/gwu/dune… Done.
Generating bin/setup/dune… Done.
Generating bin/update_nldb/dune… Done.
Generating test/dune… Done.
rm -f -r distribution
dune build -p geneweb --profile release
File "lib/gwdb-versioned/dune", line 9, characters 1-7:
9 |     syslog
     ^^^^^^
Error: Library "syslog" not found.
-> required by library "geneweb.gwdb-versioned" in
   _build/default/lib/gwdb-versioned
-> required by executable ged2gwb in bin/ged2gwb/dune:2
-> required by _build/default/bin/ged2gwb/ged2gwb.exe
-> required by _build/install/default/bin/ged2gwb.exe
-> required by _build/default/geneweb.install
-> required by alias install
(cd _build/default && .ppx/c3461e88ae1503d575d582eb5874e916/ppx.exe -o bin/gwrepl/data.pp.ml --impl bin/gwrepl/data.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
File "data.cppo.ml", line 1, characters 22-24:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
File "data.cppo.ml", line 1, characters 26-28:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
File "data.cppo.ml", line 1, characters 38-40:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
File "data.cppo.ml", line 1, characters 42-44:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
File "data.cppo.ml", line 1, characters 48-50:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
make: *** [Makefile:128: distrib] Error 1

canonici · 2023-05-15T07:45:13Z

as make distrib still lacks from Github CI here is what I have for this branch on Windows

ocaml ./configure.ml --sosa-legacy --gwdb-legacy --release

$ make distrib
cat dune-workspace.in | sed  -e "s/%%%DUNE_PROFILE%%%/release/g" > dune-workspace
Last commit is 4dfc601d2 (2023-05-12).
Generating hd/etc/version.txt… Done.
Generating lib/dune… Done.
Generating lib/gwdb/dune… Done.
Generating lib/core/dune… Done.
Generating lib/util/dune… Done.
Generating lib/system_util/dune… Done.
Generating lib/gwdb-legacy/dune… Done.
Generating lib/gwdb-versioned/dune… Done.
Generating benchmark/dune… Done.
Generating bin/connex/dune… Done.
Generating bin/consang/dune… Done.
Generating bin/fixbase/dune… Done.
Generating bin/ged2gwb/dune… Done.
Generating bin/gwb2ged/dune… Done.
Generating bin/gwc/dune… Done.
Generating bin/gwd/dune… Done.
Generating bin/gwdiff/dune… Done.
Generating bin/gwgc/dune… Done.
Generating bin/gwrepl/dune… Done.
Generating bin/gwu/dune… Done.
Generating bin/setup/dune… Done.
Generating bin/update_nldb/dune… Done.
Generating test/dune… Done.
rm -f -r distribution
dune build -p geneweb --profile release
File "lib/gwdb-legacy/dune", line 19, characters 4-15:
19 |     gwdb_driver
         ^^^^^^^^^^^
Error: The following modules are implementations of virtual modules:
- Gwdb_driver
They cannot have their own interface files.
make: *** [Makefile:128: distrib] Error 1

Is --gwdb-legacy deprecated or broken?

deprecated, it is used in the versioned gwdb, but it has no support for witness notes. We could still offer it with default implementations without support to store the notes, but I don't think it is of any use.

canonici · 2023-05-15T07:47:49Z

Without gwdb-legacy it falls back to gwdb-versionned and seems to ask for syslog (I didn't use --syslog in configure.ml)

A2@D /cygdrive/c/gw
$ ocaml ./configure.ml --release --sosa-legacy

A2@D /cygdrive/c/gw
$ make distrib
cat dune-workspace.in | sed  -e "s/%%%DUNE_PROFILE%%%/release/g" > dune-workspace
Last commit is 4dfc601d2 (2023-05-12).
Generating hd/etc/version.txt… Done.
Generating lib/dune… Done.
Generating lib/gwdb/dune… Done.
Generating lib/core/dune… Done.
Generating lib/util/dune… Done.
Generating lib/system_util/dune… Done.
Generating lib/gwdb-legacy/dune… Done.
Generating lib/gwdb-versioned/dune… Done.
Generating benchmark/dune… Done.
Generating bin/connex/dune… Done.
Generating bin/consang/dune… Done.
Generating bin/fixbase/dune… Done.
Generating bin/ged2gwb/dune… Done.
Generating bin/gwb2ged/dune… Done.
Generating bin/gwc/dune… Done.
Generating bin/gwd/dune… Done.
Generating bin/gwdiff/dune… Done.
Generating bin/gwgc/dune… Done.
Generating bin/gwrepl/dune… Done.
Generating bin/gwu/dune… Done.
Generating bin/setup/dune… Done.
Generating bin/update_nldb/dune… Done.
Generating test/dune… Done.
rm -f -r distribution
dune build -p geneweb --profile release
File "lib/gwdb-versioned/dune", line 9, characters 1-7:
9 |     syslog
     ^^^^^^
Error: Library "syslog" not found.
-> required by library "geneweb.gwdb-versioned" in
   _build/default/lib/gwdb-versioned
-> required by executable ged2gwb in bin/ged2gwb/dune:2
-> required by _build/default/bin/ged2gwb/ged2gwb.exe
-> required by _build/install/default/bin/ged2gwb.exe
-> required by _build/default/geneweb.install
-> required by alias install
(cd _build/default && .ppx/c3461e88ae1503d575d582eb5874e916/ppx.exe -o bin/gwrepl/data.pp.ml --impl bin/gwrepl/data.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
File "data.cppo.ml", line 1, characters 22-24:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
File "data.cppo.ml", line 1, characters 26-28:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
File "data.cppo.ml", line 1, characters 38-40:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
File "data.cppo.ml", line 1, characters 42-44:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
File "data.cppo.ml", line 1, characters 48-50:
Warning 14 [illegal-backslash]: illegal backslash escape in string.
make: *** [Makefile:128: distrib] Error 1

my bad, I used it to debug and forgot to remove it afterwards.

lledieu · 2023-05-18T06:45:54Z

C'est une très bonne idée de rajouter les notes pour les témoins d'un événements. Cependant, je suis surpris qu'il soit obligatoire de rattacher (ou créer) une personne pour chaque témoin. Ne serait-il pas possible de créer des témoins avec juste une note afin de se donner la possibilité de les lier plus tard à une personne ? Vous allez me dire qu'on peut créer une personne et la fusionner plus tard mais je trouve que ça alourdit inutilement la base avec plein de personnes qu'on ne saura pas fusionner...

Si on se projette un peu plus loin :

on pourrait imaginer que cette note soit au format JSON afin de structurer au maximum les données concernant la personne
on pourrait imaginer le même type de note (format JSON) pour les personnes liées à une note liée (cas de figure où la note liée est une transcription ou extrait d'un acte)
Une telle représentation aurait l'avantage de se rapprocher des préconisations du modèle GENTECH (conserver trace de l'origine des informations ainsi que des divergences rencontrées) : https://www.ngsgenealogy.org/wp-content/uploads/NGS-History/Diagram_GENTECH_Data_Model_1.0.pdf

canonici · 2023-05-29T13:31:54Z

C'est une très bonne idée de rajouter les notes pour les témoins d'un événements. Cependant, je suis surpris qu'il soit obligatoire de rattacher (ou créer) une personne pour chaque témoin. Ne serait-il pas possible de créer des témoins avec juste une note afin de se donner la possibilité de les lier plus tard à une personne ? Vous allez me dire qu'on peut créer une personne et la fusionner plus tard mais je trouve que ça alourdit inutilement la base avec plein de personnes qu'on ne saura pas fusionner...

Si on se projette un peu plus loin :

on pourrait imaginer que cette note soit au format JSON afin de structurer au maximum les données concernant la personne

on pourrait imaginer le même type de note (format JSON) pour les personnes liées à une note liée (cas de figure où la note liée est une transcription ou extrait d'un acte)
Une telle représentation aurait l'avantage de se rapprocher des préconisations du modèle GENTECH (conserver trace de l'origine des informations ainsi que des divergences rencontrées) : https://www.ngsgenealogy.org/wp-content/uploads/NGS-History/Diagram_GENTECH_Data_Model_1.0.pdf

Si je comprends bien la suggestion, il s'agirait en premier lieu de faire en sorte que les notes puissent avoir leur existence propres indépendamment de tout individu, événement ou famille, puis de permettre de produire des liens vers les dites notes. Quelque chose comme ça ?

…system_util

…escends

This reverts commit 3666923. Because of wiki syntax we need to insert "<br>" in notes so it looks like in other software... This is bad and should not be done like this. User data should not be modified. This is buggy on export/import cycle in .gw/.ged

…dle erased persons and families when traversing the base

canonici force-pushed the integration-master-gnt branch 4 times, most recently from ef60dbf to 4dfc601 Compare May 12, 2023 14:04

canonici force-pushed the integration-master-gnt branch 2 times, most recently from 2cc8837 to 877229b Compare May 15, 2023 13:53

Swrup mentioned this pull request Jun 9, 2023

[BUG] gwu/gwc cycle changes some data (unions) #1496

Closed

Elie Canonici Merle added 17 commits August 3, 2023 10:19

expand persons jingoo to access visibility

a85a02d

jingoo access -> access_url

22910de

fix access_url

d2e96f6

fix missing space in advanced search fields date display

7029df1

fix missing space

fa89c34

allow to set timeout handler

b1a9d1b

moved some functions to a files module + moved secure out of util to …

a175176

…system_util

handle multiple implementations of base structures

1404f33

read_or_create_channel

ac92a36

fix dune

8d98e1b

log

29dd6e4

fix get_pevents

a82d225

update perso templ interpreter to handle witness notes

9a131f4

deactivate logs

c09818b

more logs deactivation

c196af6

fix rebase

e26fa50

support for family witness notes

ebb7864

Elie Canonici Merle and others added 21 commits August 3, 2023 11:44

clear cache upon deletion

d184821

do not attempt to export dummy persons

23e123e

invalidate caches unpon modifications of unions couples ascends and d…

02f6274

…escends

desactivate cache when loading arrays

83f57cc

fix escaped # in wiki-text links

f4408ee

build data from scratch using max index instead of table length + han…

3df9472

…dle erased persons and families when traversing the base

return None for out of bounds index when reading data from file

17a94dc

fix rebase remnants

bd65566

remove unused code and correct warnings

8c0a875

update forms to handle witness notes

9fbb50f

format

48cd569

update test/gwdb_driver.ml

fffe607

update tests for gedcom import/export

1409064

open in binary mode

967b2f5

clean dune file

2402f8d

output errors on stderr

772e636

fix

ca69de5

fix double multiple declaration of is_public

9a77601

Mutil -> Files

b973a06

fmt

ed2b8cc

canonici force-pushed the integration-master-gnt branch from 877229b to ed2b8cc Compare August 3, 2023 10:40

Elie Canonici Merle added 2 commits August 3, 2023 14:10

fix warning

5194384

portable test

5656cc6

canonici force-pushed the integration-master-gnt branch from 55afe6c to 5656cc6 Compare August 3, 2023 12:47

canonici mentioned this pull request Aug 4, 2023

Pré-release 7.01 alpha, ne fonctionne pas pour Windows #1510

Closed

This was referenced Aug 12, 2023

Incompatibilité import GW 7.00 Local avec sauvegarde GW (version Geneanet avec notes pour les témoins) #1450

Open

[BUG] abnormal 'note' word in many lines of gw file output of gwu cmd from PR #1481 #1530

Closed

Swrup mentioned this pull request Aug 22, 2023

Fix management of gwu -odir #1543

Merged

Swrup mentioned this pull request Nov 15, 2023

Some fixes for gwu/gwc (updated) #1487

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Witness notes #1481

Witness notes #1481

canonici commented May 11, 2023

a2line commented May 14, 2023 •

edited

a2line commented May 14, 2023

canonici commented May 15, 2023

canonici commented May 15, 2023

lledieu commented May 18, 2023

canonici commented May 29, 2023

Witness notes #1481

Are you sure you want to change the base?

Witness notes #1481

Conversation

canonici commented May 11, 2023

a2line commented May 14, 2023 • edited

a2line commented May 14, 2023

canonici commented May 15, 2023

canonici commented May 15, 2023

lledieu commented May 18, 2023

canonici commented May 29, 2023

a2line commented May 14, 2023 •

edited