confidentiality clean up #1433
Draft
confidentiality clean up #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would rename |
canonici
approved these changes
Mar 6, 2023
Swrup
force-pushed
the
private
branch
2 times, most recently
from
eb629df
to
166c7f7
Compare
…y referenced in the anomaly
remove condition on wizard or friend from conf.hide_names report this change where conf.hide_private_names is used TODO: maybe use a "is_hidden" function instead where conf.hide_private_names is used; and make it check if more conditions; it looks buggy when we use conf.hide_private_names directly
added 2 commits
July 31, 2023 12:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.