import/export: clean up, add test #1418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapashcanon
reviewed
Jan 20, 2023
Add test for multiline NOTE, Original author is hgouraud
To re-import wiki notes and link them correctly we need file name information
zapashcanon
reviewed
Feb 2, 2023
| let () = Gwdb.load_couples_array base in | ||
| let () = Gwdb.load_unions_array base in | ||
| let () = Gwdb.load_descends_array base in | ||
| ()); |
zapashcanon
reviewed
Feb 2, 2023
| let read_file_content filename = | ||
| let ic = Secure.open_in filename in | ||
| let s = input_file_ic ic in | ||
| close_in ic; |
There was a problem hiding this comment.
You should use Fun.protect :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that I added royal92.ged for tests but maybe we can use a smaller one