[Enhancement 3.2 3.3] COT, TOT strategy for engineer role #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekan
reviewed
Sep 19, 2023
|
|
||
| import asyncio | ||
|
|
||
| @pytest.mark.asyncio |
| @@ -0,0 +1,29 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: utf-8 -*- | |||
metagpt/actions/action.py
Outdated
| @@ -39,11 +41,20 @@ def __str__(self): | |||
| def __repr__(self): | |||
| return self.__str__() | |||
|
|
|||
| async def _aask(self, prompt: str, system_msgs: Optional[list[str]] = None) -> str: | |||
| async def _aask(self, prompt: str, strategy: PromptStrategyType = None, task: Task = None, system_msgs: Optional[list[str]] = None) -> str: | |||
metagpt/actions/action.py
Outdated
| task.task_args_pool[output_key] = await self._aask(PROMPT) | ||
| prompt = PROMPT | ||
| elif strategy == PromptStrategyType.TREE_OF_THOUGHT: | ||
| pass |
| @@ -0,0 +1,12 @@ | |||
| from typing import Dict | |||
| ATTENTION: Use '##' to SPLIT SECTIONS, not '#'. Output format carefully referenced "Format example". | ||
| ----- | ||
| ## Step by Step Implementation Plan: {filename} | ||
| """ |
metagpt/actions/write_code.py
Outdated
| }, | ||
| # an ordered list of prompt output keys | ||
| task_output_keys = ["plan", "code"]) | ||
| code = await self.write_code('', strategy = strategy, task = task) |
stellaHSR
reviewed
Dec 4, 2023
|
|
||
| for _ in max_num_rounds: | ||
| for prompt_template, step_output in zip(self.task.prompts, self.task.task_output_keys): | ||
| message = self.prompter.generate_initial_prompt(prompt_template, **self.task.task_args_pool) |
There was a problem hiding this comment.
what is prompter? I think init first would be better
weburnit
reviewed
Dec 8, 2023
| @@ -0,0 +1,31 @@ | |||
| class ChainOfThoughtBase(object): | |||
There was a problem hiding this comment.
from abc import ABC
class ChainOfThoughtBase(ABC):
|
Please resolve all conflicts and Review comments @LeonZh0u |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP implemented COT, will push TOT if the current way of calling aask() makes sense