feature/write many code #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaHSR
reviewed
Sep 12, 2023
| from metagpt.utils.special_tokens import FILENAME_CODE_SEP, MSG_SEP | ||
|
|
||
|
|
||
| class WriteManyCodes(Action): |
There was a problem hiding this comment.
why use this name? Is WriteCodes good enough?
There was a problem hiding this comment.
hello, 1. WriteCodes will be similar to WriteCode action, so it's easy for programmer to make mistake.
2.Action will be triggered by plan/thought, basically we need
action, action params, action description,
so with WriteCodes similar to WriteCode, llm will be more easy to pick the wrong action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplifies Engineer and refactor core logic into WriteManyCodes.
the concern is, 1. the logic belongs to Action
2.when going to WriteManyCodes action, it can be triggered by other means.