Add node version and licence details #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mde
reviewed
Feb 28, 2017
| @@ -54,8 +54,22 @@ https://www.digitalocean.com/community/articles/geddy-js-a-no-brainer-mvc-node-j | |||
|
|
|||
| #### License | |||
|
|
|||
| Apache License, Version 2 | |||
| Copyright 2017. Geddy - Web-app development framework | |||
There was a problem hiding this comment.
All our copyrights are listed as 2112, because of this: https://en.wikipedia.org/wiki/2112_(album)
Also, this means we don't have to keep going around keeping a copyright year number up to date. :)
Oh, and also I guess technically I do own the copyright, so it's not really necessary to change either of those lines.
|
Ideally it shouldn't include an actual year number, but we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will update the README.md with clearer details on which node version to use and the project licence. It will fix the 'WARN' message about the missing
licenseentry whennpm installis run.Please merge this into the branch called 'develop', if my other pull request is accepted (#728).