Allow decimals in number (float) type input + builtinAdaptersPath fix #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As opposed to the input used for int type.
gabriel-alecu
changed the title
gabriel-alecu
changed the title
|
@gabe-alex Looks like tests are failing. This looks great -- let's get tests passing and merge it! |
|
@mde Yeah, the tests have been failing for a while, it affected a few pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small edit for the scaffold views.
Since the number type is meant to allow for floats (as opposed to the int type), I think the form inputs used for it should also accept floats.
Also, made builtinAdaptersPath automatically detect model's install location, in order to fix a case where it would break if using a local geddy install with npm's new flat dependency arrangement.